-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show alignment info when parent layout is constrained. #49703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +14 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up @tellthemachines, this is testing nicely!
Post Content block set to constrained | Post content block set to flow layout |
---|---|
![]() |
![]() |
LGTM! ✨
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 799fc32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Layout
Layout block support, its UI controls, and style output.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up from #49565, where testing brought up that the info in "none" option in the alignment controls doesn't always reflect the actual content width.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast <!-- if a
![Screenshot 2023-04-11 at 10 56 04 am](https://user-images.githubusercontent.com/8096000/231027832-e2d98d3b-2f10-42fc-9027-78b440fb60a9.png)
pplicable -->